From 2977075a4b7f4caa8788472aeb1082e692275e80 Mon Sep 17 00:00:00 2001 From: cyian-1756 Date: Thu, 24 May 2018 13:43:54 -0400 Subject: [PATCH 1/2] Now checks that URLHistory exists and that we can write to it before trying to write to it --- .../java/com/rarchives/ripme/ripper/AbstractRipper.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java b/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java index 20889495..91fc9698 100644 --- a/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java +++ b/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java @@ -72,6 +72,14 @@ public abstract class AbstractRipper FileWriter fw = null; try { File file = new File(URLHistoryFile); + if (!new File(Utils.getConfigDir()).exists()) { + logger.error("Config dir doesn't exist"); + return; + } + if (!file.canWrite()) { + logger.error("Can't write to url history file: " + URLHistoryFile); + return; + } // if file doesnt exists, then create it if (!file.exists()) { file.createNewFile(); From ef1cab60e1f105111da4013e0d614ef72e89126a Mon Sep 17 00:00:00 2001 From: cyian-1756 Date: Fri, 25 May 2018 01:14:39 -0400 Subject: [PATCH 2/2] Ripme now makes config dir and url_history file if they do not exist --- .../ripme/ripper/AbstractRipper.java | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java b/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java index 91fc9698..f32b66d1 100644 --- a/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java +++ b/src/main/java/com/rarchives/ripme/ripper/AbstractRipper.java @@ -74,16 +74,25 @@ public abstract class AbstractRipper File file = new File(URLHistoryFile); if (!new File(Utils.getConfigDir()).exists()) { logger.error("Config dir doesn't exist"); - return; + logger.info("Making config dir"); + boolean couldMakeDir = new File(Utils.getConfigDir()).mkdirs(); + if (!couldMakeDir) { + logger.error("Couldn't make config dir"); + return; + } + } + // if file doesnt exists, then create it + if (!file.exists()) { + boolean couldMakeDir = file.createNewFile(); + if (!couldMakeDir) { + logger.error("Couldn't url history file"); + return; + } } if (!file.canWrite()) { logger.error("Can't write to url history file: " + URLHistoryFile); return; } - // if file doesnt exists, then create it - if (!file.exists()) { - file.createNewFile(); - } fw = new FileWriter(file.getAbsoluteFile(), true); bw = new BufferedWriter(fw); bw.write(downloadedURL);