Gurkengewuerz/ImgScroll
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

CONTRIBUTING.md: fix a few typos

Browse Source
This commit is contained in:
MetaPrime 2017-07-13 03:15:16 -07:00
parent 302f0a5a04
commit 4e2d5f3c6e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -47,9 +47,9 @@ Before you open your pull request, please consider the following:
* This helps avoid merge conflicts. * This helps avoid merge conflicts.
* Please ensure your change includes only the minimum changes needed to fix a single issue. These are easiest to review and tend to get merged more quickly. If the scope of your PR is wider than a single issue, you may be asked to reopen your PR as multiple separate PRs. * Please ensure your change includes only the minimum changes needed to fix a single issue. These are easiest to review and tend to get merged more quickly. If the scope of your PR is wider than a single issue, you may be asked to reopen your PR as multiple separate PRs.
* Are you fixing an issue from one of the issue trackers ([RipMeApp](https://github.com/RipMeApp/ripme/issues) or [4pr0n](https://github.com/4pr0n/ripme/issues))? If so, please ensure that you reference the issue you are fixing in your commit message so that it will be [automatically closed](https://help.github.com/articles/closing-issues-via-commit-messages/). * Are you fixing an issue from one of the issue trackers ([RipMeApp](https://github.com/RipMeApp/ripme/issues) or [4pr0n](https://github.com/4pr0n/ripme/issues))? If so, please ensure that you reference the issue you are fixing in your commit message so that it will be [automatically closed](https://help.github.com/articles/closing-issues-via-commit-messages/).
* Please ensure you verifying that you did not break any functionality outside of your change or feature. * Please ensure you verify that you did not break any functionality outside of your change or feature
* The CI might be broken, so please ensure that `mvn test` shows no new errors since before your change. * The CI might be broken, so please ensure that `mvn test` shows no new errors since before your change.
* Keep in mind each Ripper likely support multiple URL formats for each website, which have different content layouts (users, galleries, etc.) * Keep in mind each Ripper likely supports multiple URL formats for each website, which have different content layouts (users, galleries, etc.)
* We deal with live websites, so things might break while we aren't looking. Websites can change and content can be deleted at any time. Our code and/or tests may need to be rewritten to fix issues. * We deal with live websites, so things might break while we aren't looking. Websites can change and content can be deleted at any time. Our code and/or tests may need to be rewritten to fix issues.
* Please consider adding a test to check for regressions to the Ripper you added or the bug you fixed. * Please consider adding a test to check for regressions to the Ripper you added or the bug you fixed.
* See e.g. src/test/java/com/rarchives/ripme/tst/ripper/rippers/ImgurRipperTest.java * See e.g. src/test/java/com/rarchives/ripme/tst/ripper/rippers/ImgurRipperTest.java